Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix error in vector docs #216

Merged
merged 1 commit into from
Mar 8, 2023
Merged

Fix error in vector docs #216

merged 1 commit into from
Mar 8, 2023

Conversation

michaelpnelson
Copy link
Contributor

No description provided.

@michaelpnelson michaelpnelson requested a review from rustyjux March 8, 2023 19:15
@michaelpnelson michaelpnelson self-assigned this Mar 8, 2023
rustyjux
rustyjux approved these changes Mar 8, 2023
View reviewed changes
Copy link
Contributor

@rustyjux rustyjux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this really need a review? :P

@michaelpnelson
Copy link
Contributor Author

This is trivial, yes, but for this repo, being public, we have branch protection rules requiring at least 1 reviewer for pull requests. And it shares a wee bit of knowledge.

@michaelpnelson michaelpnelson merged commit 05f9803 into master Mar 8, 2023
@michaelpnelson michaelpnelson deleted the vector_doc_fix branch March 8, 2023 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rustyjux rustyjux rustyjux approved these changes

Assignees

@michaelpnelson michaelpnelson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@michaelpnelson @rustyjux